Replace create react app with vite #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa24126 to
cdc57b4
Compare
|
Thanks for working on this! I’ll need some time to review and test it out, but from a quick skim it looks good, and I agree with the reasoning for switching away from CRA. |
create-react-app seems to struggle a bit [1] and many folks are recommending vite as an alternative, as that project is more active. For me the reason to switch to vite is to reduce dependencies and speed up the build process. Replacing create-react-app with vite reduce the number of dependencies from 1762 to 444. I was also quite surprised, by how small the actual diff in this commit is. From that perspective there is almost no discernible difference between the two tools. [1]: reactjs/react.dev#5487 (comment)
cdc57b4 to
a3da33d
Compare
Vite does not natively ship a Buffer polyfill and most of the functionality that is required here, can be implemented natively (except for the byte-wise compare, for that I had to write my own function).
For some reason the vite-plugin-comlink doesn't seem to work in this constellation. I tried to reproduce in a new vite project and there it did work. But also, the plugin does some horrible magic by replacing a non-existant constructor `ComLinkWorker()` with the `wrap()` method and then the only real benefit is, that we wouldn't need to write the `expose()` method in the worker. So for that reason I'm removing the plugin and using the comlink package directly.
387a266 to
0701303
Compare
|
Looks good, merging. Thanks again, this is great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #163 and thus includes the changes from that PR as well. If #163 gets merged, the diff in this PR will be smaller.For reviewing purposes, you could check out the "Commits" tab and review the commits separately.
create-react-app seems to struggle a bit reactjs/react.dev#5487 (comment) and many folks are
recommending vite as an alternative, as that project is more active.
For me the reason to switch to vite is to reduce dependencies and speed
up the build process.
Replacing create-react-app with vite reduce the number of dependencies
from 1762 to 444.
I was also quite surprised, by how small the actual diff in this commit
is. From that perspective there is almost no discernible difference
between the two tools.
Not sure, if you are up for any major changes, I just forked this repository and started tinkering a bit - feel free to close it if it doesn't fit in your vision.