Add service worker and make PWA installable #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a service worker to make the app installable as a PWA. In addition to caching all generated build artifacts (css and js filse) the service worker also caches all other static files via a stale-while-revalidate strategy (png, ico, json, css from the public folder). Further, this commit adds a Notification which will be shown when the service worker updates and clicking on the button inside it causes the service worker to update and the page to reload. In order to make a PWA installable we need to follow some guide lines: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Guides/Making_PWAs_installable Fixes: cogentapps#147
06e2651 to
d5131d1
Compare
|
Thanks for working on this! In my tests, it looks like the build isn't outputting |
|
@cogentapps ah yes, this implementation relied on the workbox integration of create-react-app, so now we need to change it to vite. I found a vite-plugin-pwa and could refactor this PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a service worker to make the app installable as a PWA. In addition to caching all generated build artifacts (css and js filse) the service worker also caches all other static files via a stale-while-revalidate strategy (png, ico, json, css from the public folder).
Further, this commit adds a Notification which will be shown when the service worker updates and clicking on the button inside it causes the service worker to update and the page to reload.
In order to make a PWA installable we need to follow some guide lines: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Guides/Making_PWAs_installable
Fixes: #147