Allow pushing of oci images #358
Conversation
7295e58
to
22551cb
Compare
Signed-off-by: Daniel J Walsh <[email protected]>
| COPY {model} /{model_name} | ||
| """ | ||
| ) | ||
| run_cmd([self.conman, "build", "-t", target, "-f", containerfile.name, contextdir], stdout=None) |
There was a problem hiding this comment.
wouldn't this require conman to be available a system tool/dependency? 🤔
There was a problem hiding this comment.
Being able to create and push to a OCI Registry requires an OCI Container Engine.
|
Need to add tests using local oci registries to RamaLama. |
There was a problem hiding this comment.
I believe pushing a non-executable OCI Image with only containing model is a valid alternative way, given more recent K8s KEP updates.
I also believe we should seize this time as an opportunity to give relevance to Metadata of the model, see comment below.
This will also compound for benefit of putting as well Metadata under scope of Signature and Attestation.
wdyt?
| FROM scratch | ||
| COPY --from=builder /run/model / | ||
| COPY {model} /{model_name} |
There was a problem hiding this comment.
If the "source" contains metadata,
e.g. an HuggingFace Model Card
can you add a 1 layer here dedicated to it ?
This way, we can "consume" this from multiple "downstream" such as registry and model registry
(a HF Model Card is typically a markdown with a yaml frontmatter; not sure what ollama brings in terms of Metadata, but analogously)
There was a problem hiding this comment.
I would prefer to get this in, and then open PRs to add more metadata to the container image since this is just a simple Containerfile, it should be simple to enhance it.
No description provided.