Add --debug option to show exec_cmd and run_cmd commands #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
approved these changes
Oct 25, 2024
Signed-off-by: Daniel J Walsh <[email protected]>
ericcurtin
reviewed
Oct 25, 2024
| print(*args) | ||
| def exec_cmd(args, stderr=True, debug=False): | ||
| if debug: | ||
| perror("exec_cmd: ", *args) |
There was a problem hiding this comment.
Should probably do
if debug:
stderr = True
perror("exec_cmd: ", *args)
but that can be for another PR.
ericcurtin
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a bug I found when testing pulling a bogus image.
Hugginface pulls should have a similar error, but currently we execute the command line and it blows up. When we convert to using internal http we need to catch pulling a bogus image.