Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: disable osh diff scan #403

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 1, 2024

@lsm5 lsm5 marked this pull request as ready for review November 1, 2024 16:05

Verified

This commit was signed with the committer’s verified signature.
lsm5 Lokesh Mandvekar
Often takes too long and results are being ignored for now.

Ref: https://packit.dev/docs/configuration#osh_diff_scan_after_copr_build

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 force-pushed the disable-osh-diff-scan branch from 91ab95e to d51397b Compare November 1, 2024 16:06
@lsm5
Copy link
Member Author

lsm5 commented Nov 1, 2024

@rhatdan @ericcurtin @smooge hopefully that should do it. PTAL

@ericcurtin
Copy link
Collaborator

I really need to find out how to make that "Merge on green build" button appear here, we have it in OSTree repo and it's super useful, the button says "Enable auto-merge" and will merge once builds pass.

@rhatdan rhatdan merged commit 8624abb into containers:main Nov 1, 2024
11 checks passed
@rhatdan
Copy link
Member

rhatdan commented Nov 1, 2024

I think we should still require one LGTM to pass as well. Eventually would be nice to get to the point of requiring two.

@lsm5 lsm5 deleted the disable-osh-diff-scan branch November 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants