Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add granite-8b to shortnames.conf #448

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 12, 2024

Summary by Sourcery

New Features:

  • Add new shortnames for the 'granite-8b' model to the configuration file.

Copy link
Contributor

sourcery-ai bot commented Nov 12, 2024

Reviewer's Guide by Sourcery

This PR updates the shortnames configuration to add support for the new Granite 8B model while maintaining backward compatibility with Granite 7B. The changes involve updating the default "granite" shortname to point to the 8B model and adding new aliases for both 7B and 8B variants.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated default Granite model reference to 8B version
  • Changed default 'granite' shortname to point to the 8B model instead of 7B
  • Updated model path to use ibm-granite organization instead of instructlab
shortnames/shortnames.conf
Added new shortname aliases for Granite 8B model
  • Added granite-lab-8b alias
  • Added granite:8b alias
  • Added ibm/granite alias pointing to 8B model
  • Added ibm/granite:8b explicit version alias
shortnames/shortnames.conf
Reorganized 7B model aliases for consistency
  • Moved 7B-specific aliases together for better organization
  • Added ibm/granite:7b explicit version alias
shortnames/shortnames.conf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit c1ca09a into containers:main Nov 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants