Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched DGGML_CUDA to ON in cuda containerfile #459

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

bmahabirbu
Copy link
Collaborator

@bmahabirbu bmahabirbu commented Nov 15, 2024

Just a simple fix while testing Nvidia GPU support I noticed that -DGGML_CUDA should be equal to ON instead of 1. The container file will build but it won't recognize the GPU.

I tested this and everything works! (with adding -ngl to llama-chat-simple and changing the container to cuda)

Summary by Sourcery

Build:

  • Change the DGGML_CUDA flag from 1 to ON in the CUDA container file to ensure proper GPU recognition.

Copy link
Contributor

sourcery-ai bot commented Nov 15, 2024

Reviewer's Guide by Sourcery

This PR modifies the CUDA containerfile to correctly enable NVIDIA GPU support by changing the GGML_CUDA CMake flag from "1" to "ON". This change ensures proper GPU recognition during runtime.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated CMake build flag for CUDA support
  • Changed GGML_CUDA flag value from '1' to 'ON' to properly enable GPU support
  • Maintains existing linker flags configuration
container-images/cuda/Containerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bmahabirbu - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit 0b803dd into containers:main Nov 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants