Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): allow empty array as value in enableCloudwatchLogsExports + fix isuptodate check #2112

Merged

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Oct 22, 2024

Description of your changes

for RDSInstance.database:

  • allow empty array as value in spec.paramaters.enableCloudwatchLogsExports
  • fix isUpTodate-check for EnableCloudwatchLogsExports

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

na

…rts + fix isuptodate check

Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

@MisterMX MisterMX merged commit ab76e4e into crossplane-contrib:master Oct 22, 2024
9 checks passed
Copy link

Successfully created backport PR #2113 for release-0.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants