fix(cloudfront): Send zero instead of nil during create/update #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b81e57 to
9eb4893
Compare
|
@jbcjorge thanks for fix. Can you adjust the commit title to match the new PR title? |
Signed-off-by: Jorge Millán <[email protected]> This is related to crossplane-contrib#1210, the issue is arised due to the usage of the function `ToIntAsInt64` returns nil when the value is `0`. Since the AWS API for CloudFront expects an actual "Quantity: 0" value, returning nil makes the API complain with something like: ``` create failed: cannot create Distribution in AWS: InvalidParameter: 10 validation error(s) found. - missing required field, CreateDistributionInput.DistributionConfig.CacheBehaviors.Quantity. - missing required field, CreateDistributionInput.DistributionConfig.CustomErrorResponses.Quantity. ... ``` This creates the utility function `ToIntAsInt64Zero` to allow the value `0` to be converted, thus fulfilling the requirement for the CloudFront API to have a real value, even if is zero.
9eb4893 to
6e5d322
Compare
|
Successfully created backport PR #2119 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This is Fixes #1210, the issue is arised due to the usage of the function
ToIntAsInt64returns nil when the value is0. Since the AWS API for CloudFront expects an actual "Quantity: 0" value, returning nil makes the API complain with something like:This creates the utility function
ToIntAsInt64Zeroto allow the value0to be converted, thus fulfilling the requirement for the CloudFront API to have a real value, even if is zero.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested it in a productive environment where the error was happening.