Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Web identity with injected identity #2133

Merged

Conversation

christophrj
Copy link
Collaborator

Description of your changes

Fixes web identity usage with injected identity as pointed out by @geoffreyme #2127 (comment)

I have:

  • Read and followed Crossplane's contribution process.
  • Run make test to ensure this PR is ready for review.

How has this code been tested

@MisterMX MisterMX changed the title fix(aws-sdk-v1): web identity with injected identity fix: web identity with injected identity Dec 11, 2024
@MisterMX MisterMX changed the title fix: web identity with injected identity fix: Web identity with injected identity Dec 11, 2024
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very @christophrj!

@MisterMX MisterMX merged commit 0519914 into crossplane-contrib:master Dec 11, 2024
9 checks passed
Copy link

Successfully created backport PR #2136 for release-0.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants