Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification, adjusted browserlist query and configs #3501

Merged
merged 7 commits into from
Aug 4, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 3, 2021

Motivation and context

Notification when the browser does not support required features:

Screenshot from 2021-08-03 13-29-49

List of checked features:

  • window.ResizeObserver (Chrome 64, Firefox 69)
  • Object.fromEntries (Chrome 73, Firefox 63)

Adjusted browserlist expression:

  • From > 2.5% (total coverage 78%)
  • To Chrome >= 63, Firefox > 58, not IE 11, > 2% (total coverage 85%)

The reason to update is that on Chrome 63 (December, 2017) I was not able to open the interface at all (just white screen with exceptions in the browser console). Now, I am able to do it. Bundle size decreased from 5793218 bytes to 5846974 bytes.

Resolved #3429
Resolved #3402

How has this been tested?

Manual testing on Google Chrome 63, 91

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT
Siteproxy

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bsekachev bsekachev added the bug Something isn't working label Aug 3, 2021
@bsekachev bsekachev requested a review from ActiveChooN August 3, 2021 10:36
@bsekachev bsekachev removed the bug Something isn't working label Aug 3, 2021
@bsekachev bsekachev changed the title Added notification, adjusted browserlist query [WIP] Added notification, adjusted browserlist query Aug 3, 2021
Boris Sekachev added 3 commits August 3, 2021 14:41

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bsekachev bsekachev force-pushed the bs/added_notification branch from 84953fe to 2bf6e10 Compare August 3, 2021 12:18
Boris Sekachev added 2 commits August 3, 2021 15:28

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bsekachev bsekachev changed the title [WIP] Added notification, adjusted browserlist query [WIP] Added notification, adjusted browserlist query and configs Aug 3, 2021
@bsekachev bsekachev changed the title [WIP] Added notification, adjusted browserlist query and configs Added notification, adjusted browserlist query and configs Aug 3, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bsekachev bsekachev merged commit a12d14b into develop Aug 4, 2021
@bsekachev bsekachev deleted the bs/added_notification branch August 6, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants