fix: Show rejected posts #3900
fix: Show rejected posts #3900
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Why was the icon change needed?
You can just overwrite it with CSS?
There was a problem hiding this comment.
@rebelchris It did not work with CSS because the fill was nested and not top level,
But you are right in the sense that we could've just removed the fill all together and set it to "currentcolor" in the component and it will have the same effect!
Applying
There was a problem hiding this comment.
Ah yeah it should be fixed on the SVG, it just some icons have it accidentally set.
They should use currentcolor to support light/dark mode
| useSquadPendingPosts( | ||
| squad?.id, | ||
| isModerator | ||
| ? [SourcePostModerationStatus.Pending] | ||
| : [ | ||
| SourcePostModerationStatus.Pending, | ||
| SourcePostModerationStatus.Rejected, | ||
| ], | ||
| ); |
There was a problem hiding this comment.
status is not included in the query key so this will lead to a bug where pending/rejected posts will show the same data depending on which one is queried first.
There was a problem hiding this comment.
I recommend query key to be:
generateQueryKey(RequestKey.SquadPostRequests, user, squadId, { status })
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-645.preview.app.daily.dev