chore: remove the link if the author is not available #169
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/PackageSidebar.tsx
Outdated
| @@ -70,6 +72,14 @@ export default function PackageSidebar({ | |||
| router.push(`/packages/${packageName}/versions/${selectedVersion}`); | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
You could extract this as a hook which you can test like eg useHasCollaborator which returns a boolean. That way you can test the hook in isolation, and have a single-purpose hook for this
There was a problem hiding this comment.
needs unit test setup. creating a ticket for it
Joachimzeelmaekers
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
This pull request proposes an update to the
PackageSidebarcomponent to enhance the handling of the maintainer's information. The changes introduce a new state to track the availability of the maintainer and update the UI accordingly.Context
Following the end of Depsy back in 2018, there is no new data incoming - meaning any authors published after March 2018 will throw a 404 on the collaborator/maintainer page on rdocs.