Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMR block process number bugfix #407

Merged
merged 2 commits into from
Jun 17, 2023
Merged

NMR block process number bugfix #407

merged 2 commits into from
Jun 17, 2023

Conversation

jdbocarsly
Copy link
Member

Bruker NMR files can each have a different set of "process numbers". This PR is a small bugfix to automatically select an existing process if the block has an invalid process number selected for any reason ( i.e. if the filename has just been changed and the selected process is not a valid process number in the new experiment).

Closes #402

@jdbocarsly jdbocarsly requested a review from ml-evs as a code owner May 26, 2023 16:01
@cypress
Copy link

cypress bot commented May 26, 2023

Passing run #359 ↗︎

0 44 0 0 Flakiness 0

Details:

Merge aed6693 into 62b2c10...
Project: datalab Commit: caa7ab6816 ℹ️
Status: Passed Duration: 07:06 💡
Started: Jun 17, 2023 12:32 PM Ended: Jun 17, 2023 12:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jdbocarsly jdbocarsly force-pushed the jdb/fix_nmr_process_bug_402 branch from 3763fe5 to d0c3d98 Compare June 16, 2023 13:07
@ml-evs ml-evs force-pushed the jdb/fix_nmr_process_bug_402 branch from d0c3d98 to aed6693 Compare June 17, 2023 12:17
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been working fine on dev for a while, will merge

@ml-evs ml-evs enabled auto-merge (squash) June 17, 2023 12:17
@ml-evs ml-evs merged commit 9d6eba4 into main Jun 17, 2023
@ml-evs ml-evs deleted the jdb/fix_nmr_process_bug_402 branch June 17, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior when switching nmr filenames
2 participants