Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-login and ddev launcha, fixes #4, fixes #1, fixes #3 #5

Merged
merged 10 commits into from
Jun 22, 2022

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 5, 2022

This spiffs this up quite a lot

You can test this by

  1. Checking out this PR and using ddev get /path/to/checkout/dir or
  2. ddev get https://github.com/rfay/ddev-adminer/tarball/20220605_auto_login

@rfay rfay changed the title Add auto-login and ddev launch, fixes #4, fixes #1 Add auto-login and ddev launch, fixes #4, fixes #1, fixes #3 Jun 5, 2022
@rfay
Copy link
Member Author

rfay commented Jun 5, 2022

Hoping for your review @bserem @wotnak.

I see tests aren't running on this @bserem - If you have turned off github actions, could. you turn it on again please?

@bserem
Copy link
Collaborator

bserem commented Jun 6, 2022

Tests enabled again. I've been inactive for a while, several things on my shoulders atm.

README.md Show resolved Hide resolved
@tyler36
Copy link
Collaborator

tyler36 commented Jun 10, 2022

Just tried this but am getting an error.

  1. Confirmed project works OK
$ ddev start
...
Your project can be reached at https://adminer-demo.ddev.site
  1. Add admin via PR
$ ddev get https://github.com/rfay/ddev-adminer/tarball/20220605_auto_login
...
Downloaded add-on https://github.com/rfay/ddev-adminer/tarball/20220605_auto_login, use `ddev restart` to enable. 
  1. Restart project
$ ddev restart
Failed to restart adminer-demo: container(s) failed to become healthy after 61 seconds. This may be just a problem with the healthcheck and not a functional problem. container 'adminer' exited, please use 'ddev logs -s adminer' to find out why it failed 
  1. Get error
$ ddev logs -s adminer
/usr/local/bin/entrypoint.sh: line 14: can't create plugins-enabled/001-tables-filter.php: Permission denied

OS: Ubuntu 20.04 via WSL2 on Win10
DDEV: vHEAD-486d701
config.yaml

php_version: "7.3"
database:
  type: postgres
  version: "10"

@tyler36
Copy link
Collaborator

tyler36 commented Jun 10, 2022

Same error on another modern project:

$ ddev logs -s adminer
/usr/local/bin/entrypoint.sh: line 14: can't create plugins-enabled/001-tables-filter.php: Permission denied
  • ./.ddev/config.yaml
name: dev93
type: drupal9
docroot: web
php_version: "8.0"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
database:
  type: mariadb
  version: "10.3"
nfs_mount_enabled: false
mutagen_enabled: false
use_dns_when_possible: true
composer_version: "2"
web_environment: []
nodejs_version: "16"

@rfay
Copy link
Member Author

rfay commented Jun 10, 2022

I saw this too, and it's what made the tests fail. Was working before, not sure what changed. Will return, thanks for trying it out!

@rfay rfay changed the title Add auto-login and ddev launch, fixes #4, fixes #1, fixes #3 Add auto-login and ddev launcha, fixes #4, fixes #1, fixes #3 Jun 16, 2022
@rfay
Copy link
Member Author

rfay commented Jun 16, 2022

Please give this another try @bserem @tyler36 - thanks, think it should be good to go now.

@tyler36
Copy link
Collaborator

tyler36 commented Jun 17, 2022

Confirmed working

  • Project 1

    • Drupal 9.3
    • PHP 8.0
    • Maria 10.3
  • Project 2

    • Laravel 7.2
    • PHP 7.2
    • Postgre 10
  • It did not auto-login, but it did populate the login screen with correct credentials; I had to click login button

  • It displayed the UI in Japanese by default (I use Japanese OS) 👍

One "issue":

  • If I change the UI to English, I can't logout. I am redirected to the login screen, and it auto-login me back to the DB page.
  • If I change the langauge to Japanese and logout, I'm redirected back to the login screen

Perhaps this is related to the way you "auto-login" which is why it originally didn't auto-login me to begin with.
It also does this with Arabic, Thai but not German.

ddev version vHEAD-486d701

@rfay
Copy link
Member Author

rfay commented Jun 17, 2022

Thanks @tyler36 - Lots of languages!

@rfay rfay merged commit 2e0810d into ddev:main Jun 22, 2022
@rfay rfay deleted the 20220605_auto_login branch June 22, 2022 18:42
@rfay
Copy link
Member Author

rfay commented Jun 22, 2022

@bserem Please give this a try, and let's promote this when you think it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants