Add optional persistence to Redis by using named volume #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
approved these changes
Nov 28, 2023
hussainweb
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
I got a little confused with changes in #18 but then I see that was closed without merging. This LGTM.
|
Please merge and create a release if it manually tests OK for you, thanks! |
|
I was literally just looking for some way to enable persistence, perfect timing for merging this 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
We need to get rid of anonymous Redis
/datavolume.How This PR Solves The Issue
Adds a named volume for Redis.
This change is not breaking, Redis will work as before, but won't create anonymous volumes on every
ddev restart.I could enable persistence by default, but I've never needed it, I've always used Redis as a cache.
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes