-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acknowledge JetBrains IDE licenses #310
Conversation
Deploying ddev-com-front-end with
|
Latest commit: |
5c55ee9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://aed0df4d.ddev-com-front-end.pages.dev |
Branch Preview URL: | https://20250124-stasadev-jetbrains.ddev-com-front-end.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still have to added it to the featured sponsors json, see README.
729201f
to
6b75fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's great!
I would like to figure out in the long term how to fiddle with the sizes of the logos. Here both Webikon and Jetbrains are a little too big. I know we could do it by adding a new category of sponsors as I did with the higher-level sponsors (Platform) but being able to just tweak a particular logo like here would be something for the future.
I made both of them smaller, nothing fancy, just reduced the width on the svg by 50px/50mm. |
I also tried to make the Centarro smaller, but the next icon from the third row goes to the second row and it looks better as it is now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks!
The Issue
Jetbrains will now sponsor IDE licenses for our project, Thanks!
They require acknowledgement on the repository README or elsewhere.
How This PR Solves The Issue
Adds JetBrains logos to ddev.com to avoid issues if the logos are moved elsewhere in the future.
Logos sources:
Manual Testing Instructions
https://aed0df4d.ddev-com-front-end.pages.dev/
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes