Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge JetBrains IDE licenses #310

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jan 24, 2025

The Issue

Jetbrains will now sponsor IDE licenses for our project, Thanks!

They require acknowledgement on the repository README or elsewhere.

How This PR Solves The Issue

Adds JetBrains logos to ddev.com to avoid issues if the logos are moved elsewhere in the future.

Logos sources:

Manual Testing Instructions

https://aed0df4d.ddev-com-front-end.pages.dev/

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2025

Deploying ddev-com-front-end with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c55ee9
Status: ✅  Deploy successful!
Preview URL: https://aed0df4d.ddev-com-front-end.pages.dev
Branch Preview URL: https://20250124-stasadev-jetbrains.ddev-com-front-end.pages.dev

View logs

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have to added it to the featured sponsors json, see README.

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk
@stasadev stasadev changed the title Add JetBrains logos Acknowledge JetBrains IDE licenses Jan 24, 2025

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk
@stasadev stasadev force-pushed the 20250124_stasadev_jetbrains_logos branch from 729201f to 6b75fcd Compare January 24, 2025 15:55
@rfay rfay self-requested a review January 24, 2025 16:01
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's great!

I would like to figure out in the long term how to fiddle with the sizes of the logos. Here both Webikon and Jetbrains are a little too big. I know we could do it by adding a new category of sponsors as I did with the higher-level sponsors (Platform) but being able to just tweak a particular logo like here would be something for the future.

Verified

This commit was signed with the committer’s verified signature.
stasadev Stanislav Zhuk
@stasadev
Copy link
Member Author

stasadev commented Jan 24, 2025

Here both Webikon and Jetbrains are a little too big

I made both of them smaller, nothing fancy, just reduced the width on the svg by 50px/50mm.

@stasadev
Copy link
Member Author

I also tried to make the Centarro smaller, but the next icon from the third row goes to the second row and it looks better as it is now.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@stasadev stasadev merged commit 255a690 into main Jan 24, 2025
2 checks passed
@stasadev stasadev deleted the 20250124_stasadev_jetbrains_logos branch January 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants