Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDEV maintainer job description, fixes ddev/ddev#4867 #53

Merged
merged 11 commits into from
May 21, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented May 19, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 19, 2023

@rfay rfay marked this pull request as ready for review May 19, 2023 23:37
@rfay rfay requested a review from mattstein May 19, 2023 23:37
@rfay rfay changed the title Add DDEV maintainer job description Add DDEV maintainer job description, fixes ddev/ddev#4867 May 20, 2023
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src: /public/img/blog/2023/05/diverse_group_of_people_sitting_at_a_table_working.png
alt: Image of a diverse group of maintainers sitting at a table maintaining DDEV
categories:
- Announcements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little strange to me that this is an announcement with a title you’d expect for an announcement, but it doesn’t actually announce anything and leaps straight into a job description—not in a careers section but in the blog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions on how to categorize it? I initially started with something random, and that failed right away, didn't see first off how to add new category.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hardcoded categories into the content definition with the intention of keeping them consistent, which may be too extreme.

But I wouldn’t recategorize it, I’d write the post as an announcement by giving it a proper introduction.

If it’s worth making a category for job listings, and those listings won’t stay up perpetually (like blog posts presumably should), it’d make more sense to make a separate hiring or careers page instead. Then use the blog to promote new positions if/when necessary instead of being their canonical home.

src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
@rfay rfay force-pushed the 20230519_maintainer_job_desc branch from c8c175a to fac05e8 Compare May 20, 2023 20:04
@rfay
Copy link
Member Author

rfay commented May 21, 2023

Good suggestions and thanks @mattstein , it's more of an announcement now, would love another quick scan.

Copy link
Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads much better to me! I fixed the image format and filename and left more suggestions.

src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
src/content/blog/maintainer-job-description.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! Merge away if you’d like, or tell me if I should push The Button.

@rfay rfay merged commit 8d7d164 into main May 21, 2023
@rfay rfay deleted the 20230519_maintainer_job_desc branch May 21, 2023 19:24
@rfay
Copy link
Member Author

rfay commented May 21, 2023

Thanks so much for your help on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants