Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dependabot/fetch-metadata
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8348ea7
Choose a base ref
...
head repository: dependabot/fetch-metadata
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0fb2170
Choose a head ref
  • 3 commits
  • 8 files changed
  • 5 contributors

Commits on Mar 21, 2024

  1. Upgrade from node16 to node20 (#443) 

    * Upgrade from node16 to node20

node16 is now EOL

* Ugrade node and npm versions

* Use the GitHub Actions reporter to stop failing on core.setFailure tests

* `npm >= 10` requires `node >= 20.5.0`

Co-authored-by: Paul <[email protected]>

---------

Co-authored-by: Jeff Widman <[email protected]>
Co-authored-by: Paul <[email protected]>
    @Nishnha @jeffwidman @hanseartic
    3 people authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    f2f0ad1 View commit details
    Browse the repository at this point in the history

  2. v2 is the new tracking tag (#506) 

    We're about to cut a new major version of this action,
and we don't anticipate any further releases of the `v1`
line.

So I simply updated the automation to float the `v2` tag.

Technically we could make it so it intelligently looks at
the release number and updates the appropriate tag, but
that'd be a bit more work and we don't need that complexity
in this repo right now given our very infrequent cadence of
bumping major versions.

As explained in a [code comment](https://github.com/dependabot/fetch-metadata/blob/f2f0ad1522845af9cf040e91326888ed5d56e3f8/.github/workflows/release-move-tracking-tag.yml#L11-L28):
```
    # We have a choice - defensiveness vs convenience:
    # 1. Be defensive by filtering if the release doesn't look like a normal
    #    version, or if it's a patch release to an older version... the logic
    #    gets tricky quickly. Easiest way to be 100% sure is stop running this
    #    on `release` and instead require a human to manually run this workflow
    #    after they tag a release.
    # 2. Minimize the upfront hassle by assuming every release is a normal
    #    version release and the latest one. Today both are resoundingly true
    #    as this repo isn't that active/busy, so we don't worry about
    #    multiple release branches, pre-releases, etc.
    #
    # For now I've gone with option 2, as it is much more convenient and if we
    # typo something during a release it's easy to fix by immediately tagging a
    # correct release. And if we don't notice the typo, well, in that case
    # requiring a human to manually run the workflow wouldn't have protected us
    # either, we'd have had to filter by only things that look like versions.
    # Anyway, for now this is good enough, and if it gets to be a problem down
    # the road we increase the robustness of this.

```
    @jeffwidman
    jeffwidman authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    dc2c459 View commit details
    Browse the repository at this point in the history

  3. v2.0.0 (#508) 

    Release notes: https://github.com/dependabot/fetch-metadata/releases/tag/v2.0.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @fetch-metadata-action-automation @github-actions
    fetch-metadata-action-automation[bot] and github-actions[bot] authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0fb2170 View commit details
    Browse the repository at this point in the history
Loading