Handle PHP 8.1 types in proxies #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3176eac
to
603ba0d
Compare
603ba0d
to
0f5aafd
Compare
malarzm
commented
Dec 21, 2021
| @@ -121,6 +121,8 @@ public function testDisablesOutput() | |||
| * @param array<string, int> $expected | |||
| * | |||
| * @dataProvider provideAttributesCases | |||
| * | |||
| * @requires PHP < 8.1.0 | |||
There was a problem hiding this comment.
Somehow PHP 8.1 changed return order of stuff that Debug is returning. Given Debug is deprecated I'm not going to invest time in fixing its tests for newer PHP versions.
For the record, test fails with:
1) Doctrine\Tests\Common\Util\DebugTest::testExportParentAttributes with data set "different-attributes" (Doctrine\Tests\Common\Util\TestAsset\ChildClass Object (...), array(4, 5, 6, 1, 2, 3))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
'(
+ [childPublicAttribute] => 4
+ [childProtectedAttribute:protected] => 5
+ [childPrivateAttribute:Doctrine\Tests\Common\Util\TestAsset\ChildClass:private] => 6
[parentPublicAttribute] => 1
[parentProtectedAttribute:protected] => 2
[parentPrivateAttribute:Doctrine\Tests\Common\Util\TestAsset\ParentClass:private] => 3
- [childPublicAttribute] => 4
- [childProtectedAttribute:protected] => 5
- [childPrivateAttribute:Doctrine\Tests\Common\Util\TestAsset\ChildClass:private] => 6
)
'
/home/runner/work/common/common/tests/Doctrine/Tests/Common/Util/DebugTest.php:133
2) Doctrine\Tests\Common\Util\DebugTest::testExportParentAttributes with data set "same-attributes" (Doctrine\Tests\Common\Util\TestAsset\ChildWithSameAttributesClass Object (...), array(4, 5, 6, 3))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
'(
[parentPublicAttribute] => 4
[parentProtectedAttribute:protected] => 5
+ [parentPrivateAttribute:Doctrine\Tests\Common\Util\TestAsset\ChildWithSameAttributesClass:private] => 6
[parentPrivateAttribute:Doctrine\Tests\Common\Util\TestAsset\ParentClass:private] => 3
- [parentPrivateAttribute:Doctrine\Tests\Common\Util\TestAsset\ChildWithSameAttributesClass:private] => 6
)
'
There was a problem hiding this comment.
PHP 8.1 changed the order in which class memebers appear if an object is cast to an array.
derrabus
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using
neverand intersection types in proxied classes. Fixes #948