Fix PHPUnit deprecations #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add4baf
to
62c2914
Compare
malarzm
commented
Aug 8, 2022
| @@ -193,13 +192,16 @@ static function () use ($test) { | |||
| self::assertSame('publicAssociationValue', $this->lazyObject->publicAssociation); | |||
| } | |||
|
|
|||
| /** | |||
| * @requires PHP >= 7.2 | |||
There was a problem hiding this comment.
expectNotice does not exist in PHPUnit running on 7.1. I figured the test can be skipped as this is tested in higher versions anyway but I can also check for expectNotice existence and conditionally call old method.
There was a problem hiding this comment.
I can also check for
expectNoticeexistence and conditionally call old method.
I'd prefer that. You could also polyfill expectNotice with a trait.
|
For 3.3.x since it affects the test suite only? |
62c2914
to
457b513
Compare
derrabus
approved these changes
Aug 8, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title :)