Improve developer experience #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm interesting that 1 test started to fail 🤔 |
I think that test case may be flakey, have seen failures for it in other branches too |
stanhu
added a commit
to stanhu/doorkeeper
that referenced
this pull request
Oct 24, 2024
doorkeeper-gem#1736 broke tests for Rails < 7.1 because these versions compared `config.action_dispatch.show_exceptions == false`. Conditionally set this value in the test set up to fix the broken tests.
|
This change broke tests for Rails < 7.1: #1742. I don't think this was flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Whilst working on #1735, I noticed it was hard to debug the code, this change adds a fairly opinionated way to debug the code when developing the doorkeeper gem. Additionally I've fixed the warning in the tests that I mentioned in #1732.
Now when developing in either the code or the specs, you can use the
debuggerkeyword to jump into an interactive debugging session.Other Information
Why include irb in the Gemfile? That's been recommended by the irb authors, due to irb bundled with ruby frequently being out of date with the state of irb development.