Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job label on k8s-views-global.json #110

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dotdc
Copy link
Owner

@dotdc dotdc commented Apr 29, 2024

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • Added a job variable to k8s-views-global.json to fix node_* metrics for both different use cases (node_exporter, grafana agent...)

Optional Fields

✔️ Which issue(s) this PR fixes?

@uhthomas
Copy link
Contributor

Only Q: Should this use =~ and allow an 'All' option?

@dotdc
Copy link
Owner Author

dotdc commented Apr 29, 2024

I don't think it's necessary, but we can still discuss it later if someone has a use-case for it.

@dotdc dotdc merged commit 13bb54f into master Apr 29, 2024
1 check passed
@dotdc dotdc deleted the fix/job-label-on-k8s-views-global.json branch April 29, 2024 11:30
@dotdc
Copy link
Owner Author

dotdc commented Apr 29, 2024

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants