Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from dotnet/standard #38384

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 9, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/standard

  • Build: 20190609.2
  • Date Produced: 6/9/2019 1:28 PM
  • Commit: bd6352a676bffc41168c7bc7e8196059f50be677
  • Branch: refs/heads/master
  • Updates:
    • NETStandard.Library -> 2.1.0-prerelease.19309.2

From https://github.com/dotnet/standard

  • Build: 20190610.1
  • Date Produced: 6/10/2019 12:36 PM
  • Commit: 7627b448f2f3ec5d4b9b4cb1471a55de78664f88
  • Branch: refs/heads/master
  • Updates:
    • NETStandard.Library -> 2.1.0-prerelease.19310.1

From https://github.com/dotnet/standard

  • Build: 20190610.2
  • Date Produced: 6/10/2019 1:31 PM
  • Commit: e75da991bda6776943dbeb7860d224d253257afe
  • Branch: refs/heads/master
  • Updates:
    • NETStandard.Library -> 2.1.0-prerelease.19310.2

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 9, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Linux musl_x64_Release), corefx-ci (Linux arm64_Release), corefx-ci (Linux x64_Release), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)

@wtgodbe
Copy link
Member

wtgodbe commented Jun 10, 2019

Crypto test failure appears to be new:

System.Security.Cryptography.Xml.Tests.SigningAndVerifyingWithCustomSignatureMethod.SignedXmlHasVerifiableSignature(signatureMethod: "http://www.w3.org/2001/04/xmldsig-more#rsa-sha384\", digestMethod: "http://www.w3.org/2001/04/xmldsig-more#sha384\")

Internal.Cryptography.CryptoThrowHelper+WindowsCryptographicException : Unknown error (0xc0000001)

at Internal.Cryptography.CngCommon.SignHash(SafeNCryptKeyHandle keyHandle, ReadOnlySpan`1 hash, AsymmetricPaddingMode paddingMode, Void* pPaddingInfo, Int32 estimatedSize) in //src/Common/src/Internal/Cryptography/CngCommon.SignVerify.cs:line 30
at System.Security.Cryptography.RSAImplementation.RSACng.SignHash(Byte[] hash, HashAlgorithmName hashAlgorithm, RSASignaturePadding padding) in /
/src/Common/src/System/Security/Cryptography/RSACng.SignVerify.cs:line 82
at System.Security.Cryptography.RSAPKCS1SignatureFormatter.CreateSignature(Byte[] rgbHash) in //src/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/RSAPKCS1SignatureFormatter.cs:line 56
at System.Security.Cryptography.AsymmetricSignatureFormatter.CreateSignature(HashAlgorithm hash) in /
/src/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/AsymmetricSignatureFormatter.cs:line 22
at System.Security.Cryptography.Xml.SignedXml.ComputeSignature() in //src/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs:line 422
at System.Security.Cryptography.Xml.Tests.SigningAndVerifyingWithCustomSignatureMethod.SignXml(XmlDocument doc, RSA key, String signatureMethod, String digestMethod) in /
/src/System.Security.Cryptography.Xml/tests/Samples/SigningVerifyingWithCustomSignatureMethod.cs:line 46
at System.Security.Cryptography.Xml.Tests.SigningAndVerifyingWithCustomSignatureMethod.SignedXmlHasVerifiableSignature(String signatureMethod, String digestMethod) in /_/src/System.Security.Cryptography.Xml/tests/Samples/SigningVerifyingWithCustomSignatureMethod.cs:line 76

@bartonjs does this appear familiar to you?

@bartonjs
Copy link
Member

I think we've seen it happen before, but given that the code is just STATUS_UNSUCCESSFUL I think it means the Windows crypto has had a bad hiccup. (https://github.com/dotnet/corefx/issues/37994 -- decryption instead of signing, but still a "Windows says something unexpected went wrong")

@wtgodbe wtgodbe merged commit e0c0765 into master Jun 10, 2019
@stephentoub stephentoub deleted the darc-master-3d981b1d-3647-411b-b3f1-ec0db5c5a71d branch June 12, 2019 19:53
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants