Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from dnceng/internal/dotnet-optimization #38450

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Build: 20190610.3
  • Date Produced: 6/10/2019 2:25 PM
  • Commit: c6eebb7f1627b32d804071f189a5041fc48696b5
  • Branch: refs/heads/master
  • Updates:
    • optimization.windows_nt-x64.IBC.CoreFx -> 99.99.99-master-20190610.3

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 11, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)

@stephentoub
Copy link
Member

stephentoub commented Jun 11, 2019

@MattGal, here's another one I don't understand.
https://dev.azure.com/dnceng/public/_build/results?buildId=220040&view=logs
It shows three legs failing:

  • Linux x64_Release
  • Packaging All Configurations
  • Windows x64_Debug

All of them show as failing in Send to Helix, but clicking through to MC then only shows a single failure (on Windows).

Do you know what's going on here? I'm assuming corefx already has the fix @alexperovich made.

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)

@MattGal
Copy link
Member

MattGal commented Jun 11, 2019

@stephentoub it sounds like the same issue @alexperovich was fixing (by making the flaky tests feature non-default) but I'll double check to be sure.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 11, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)

@MattGal
Copy link
Member

MattGal commented Jun 11, 2019

OK it's not that, and it's actually pretty interesting:

  • 3 tests failed, one in each run. 2 timed out, one failed.

  • System.Net.Http.Functional.Tests on Fedora 28 had lots of cool call stack before it timed out. This looks like a real issue that needs to get investigated and/or overloading of a test server:

Log: https://helixexternalresults.blob.core.windows.net/dotnet-corefx-refs-pull-38450-merge-495a5199592b4653a9/System.Net.Http.Functional.Tests/console.0a786e92.log

System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http2+<GoAwayFrame_AbortAllPendingStreams_StreamFailWithExpectedException>d__41
  <>1__state: 13
  <>t__builder: System.Runtime.CompilerServices.AsyncTaskMethodBuilder
  <>4__this: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2
  <>7__wrap1: System.Threading.Timer
  <>7__wrap2: (null)
  <>u__1: (null)
  <server>5__4: System.Net.Test.Common.Http2LoopbackServer
  <client>5__5: System.Net.Http.HttpClient
  <sendTask1>5__6: Status: Faulted, Exception: System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.IO.IOException: The request was aborted. ---> System.Net.Http.Http2ProtocolException: The HTTP/2 request failed with protocol error 'ENHANCE_YOUR_CALM' (0xb).
   --- End of inner exception stack trace ---

... lol at the HTTP 420.

  • The packaging test (System.DirectoryServices.AccountManagement ) failed due to a plain timeout trying to report to AzDO despite having ~10 minutes to go. This step seems to randomly get slowed down, not much we can do for it other than pre-cache the AzDO test reporter stuff. That run isn't shown on MC though, because the type is test/functional/packaging/ and your view is test/functional/cli/innerloop

  • System.Net.Http.Functional.Tests having a failure on the Windows ES run looks like typical test flakiness so I didn't dig further.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 11, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)

@wtgodbe
Copy link
Member

wtgodbe commented Jun 11, 2019

CC @davidsh, @wfurt, @scalablecory, @karelz for the HTTP failure Matt mentioned. In the meantime I'll retry the failed jobs

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Windows x64_Debug), corefx-ci (Linux x64_Release), corefx-ci (Packaging All Configurations x64_Debug)

@stephentoub
Copy link
Member

for the HTTP failure Matt mentioned

That's https://github.com/dotnet/corefx/issues/38168.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 11, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Windows x64_Debug), corefx-ci (Linux x64_Release), corefx-ci (Packaging All Configurations x64_Debug)

@wtgodbe wtgodbe merged commit bca64a8 into master Jun 11, 2019
@wtgodbe wtgodbe deleted the darc-master-d6771635-e7af-4724-abeb-914d38ebb0f7 branch June 11, 2019 19:56
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants