Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[master] Update dependencies from dotnet/arcade #38597

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190615.2
  • Date Produced: 6/15/2019 4:13 PM
  • Commit: aa4285be7fab64e2b6e62e4d5688ea50931c407c
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 2.4.1-beta.19315.2
    • Microsoft.DotNet.XUnitConsoleRunner -> 2.5.1-beta.19315.2
    • Microsoft.DotNet.VersionTools.Tasks -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.ApiCompat -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.Build.Tasks.Configuration -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.Build.Tasks.Feed -> 2.2.0-beta.19315.2
    • Microsoft.DotNet.Build.Tasks.Packaging -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.CodeAnalysis -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.CoreFxTesting -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.GenAPI -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19315.2
    • Microsoft.DotNet.RemoteExecutor -> 1.0.0-beta.19315.2
    • Microsoft.DotNet.GenFacades -> 1.0.0-beta.19315.2

…615.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19315.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19315.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19315.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19315.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19315.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19315.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19315.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19315.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19315.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19315.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19315.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19315.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19315.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19315.2
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 17, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci (Windows x64_Debug)

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 17, 2019

@MattGal even though the test ran successfully, the ExitCode returned non-zero, probably because of some code that is run after the test invocation:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'future'

https://mc.dot.net/#/user/dotnet-bot/pr~2Fdotnet~2Fcorefx~2Frefs~2Fpull~2F38597~2Fmerge/test~2Ffunctional~2Fcli~2Finnerloop~2F/20190617.10/workItem/System.Security.Cryptography.X509Certificates.Tests/wilogs

@ViktorHofer ViktorHofer merged commit b5bbcb1 into master Jun 17, 2019
@ViktorHofer ViktorHofer deleted the darc-master-61a29da6-5aa1-4ddf-b1f1-199b02fa96d4 branch June 17, 2019 14:12
@MattGal
Copy link
Member

MattGal commented Jun 17, 2019

@ViktorHofer that failure on its own is a red-herring; it just means that python -c needs " not ' on Python 3, and ends up trying to install that regardless.

THis failure is called out explicitly in the XUnit result ABOVE that:

C:\helix\work\workitem>"C:\helix\work\correlation\dotnet.exe" xunit.console.dll System.Security.Cryptography.X509Certificates.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=nonnetcoreapptests -notrait category=nonwindowstests -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Security.Cryptography.X509Certificates.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Security.Cryptography.X509Certificates.Tests (found 447 of 465 test cases)
  Starting:    System.Security.Cryptography.X509Certificates.Tests (parallel test collections = on, max threads = 2)
  Finished:    System.Security.Cryptography.X509Certificates.Tests
=== TEST EXECUTION SUMMARY ===
   System.Security.Cryptography.X509Certificates.Tests  Total: 800, Errors: 0, Failed: 0, Skipped: 0, Time: 16.419s
----- end Mon 06/17/2019 13:02:21.17 ----- exit code -1073740791 ----------------------------------------------------------

Where -1073740791 == STATUS_STACK_BUFFER_OVERRUN

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 17, 2019

OK I was confused as I thought a buffer overrun would crash xunit and not allow it to post the the test execution summary.

@danmoseley
Copy link
Member

@ViktorHofer I guess this will need a bug for @bartonjs... and hopefully a dumpfile somehow...

@ViktorHofer
Copy link
Member

Done offline.

@karelz karelz added this to the 3.0 milestone Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants