Bangladesh country states table type values updated #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hafijul233
commented
Oct 4, 2022
- First fixed the unexpected ";" issue while importing the world SQL file now it can easily import to any database
- Added the division type filter on states table values for Bangladesh country as per ISO 3166 standard subdivision category name
- Added the district type filter on states table values for Bangladesh country as per ISO 3166 standard subdivision category name
- Updated district type value for Mymensingh district that was previously nulled
… type condition as disttrict and is part of division
…is division and which one district or can list them filtered
|
@hafijul233 Thanks for the PR. Can you please also remove the "Division" and "District" words from the name column? |
Cool. I may have to only remove the district word from the list. because removing the suffix (division, district) may cause a duplicate name problem as some districts and divisions have the same name. will it be okay? |
|
@hafijul233 Ok then leave it for now, i need to cleanup those duplicates soon. |
dr5hn
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.