Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1266 #1267

Merged
merged 5 commits into from
Mar 6, 2022
Merged

fixes #1266 #1267

merged 5 commits into from
Mar 6, 2022

Conversation

oleg-andreyev
Copy link
Contributor

fixes #1266

Ref. :#756 #880

garak
garak requested changes Feb 6, 2022
View reviewed changes
Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix phpstan errors?

@oleg-andreyev
Copy link
Contributor Author

Going to take a look.

@oleg-andreyev
Copy link
Contributor Author

@garak done.

@oleg-andreyev
Copy link
Contributor Author

@garak fixed phpstan once again.

@garak garak mentioned this pull request Feb 23, 2022
Closed
@garak garak merged commit 7593b60 into dustin10:master Mar 6, 2022
@oleg-andreyev oleg-andreyev deleted the fix-1266 branch March 7, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garak garak garak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File is removed even if transaction has failed
2 participants
@oleg-andreyev @garak