Create Hazelcast store from map instance#252
Merged
eko merged 2 commits intoeko:masterfrom Jun 14, 2024
Merged
Conversation
eko
approved these changes
Jun 14, 2024
Owner
eko
left a comment
There was a problem hiding this comment.
Thank you @semihbkgr, I'm not an Hazelcast expert but this code looks good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I got some insight into the Hazelcast client, I reconsidered the changes applied in #203. Creating a new Hazelcast map instance for each operation does not offer any benefits. Instead, we can safely use a single map instance for all operations, making the API clearer and more concise.