Remove plugins from prepare-fs script in init container #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebgl
requested changes
Jun 12, 2019
Contributor
sebgl
left a comment
There was a problem hiding this comment.
Generally LGTM, I think we can remove a bit more.
There is also a reference to remove in NewPrepareFSInitContainer function comment.
| ###################### | ||
| # Persist the content of bin/, config/ and plugins/ | ||
| # Persist the content of bin/ and config/ |
Contributor
There was a problem hiding this comment.
I think we don't need to persist bin & config anymore, since was mostly done for additional plugins stuff that can get installed in there.
| ###################### | ||
| # Files persistence # |
Contributor
There was a problem hiding this comment.
PLUGIN_BIN=$ES_DIR/bin/elasticsearch-plugin can also be removed?
| "$PLUGIN_BIN install --batch repository-s3", | ||
| "$PLUGIN_BIN install --batch repository-gcs", | ||
| "mv /usr/share/elasticsearch/config/* /mnt/elastic-internal/elasticsearch-config-local/", | ||
| "mv /usr/share/elasticsearch/bin/* /mnt/elastic-internal/elasticsearch-bin-local/", |
Contributor
There was a problem hiding this comment.
I think we don't need these 2 anymore (see above)
Collaborator
Author
There was a problem hiding this comment.
Actually I think I need to revert the last commit and restore the plugin mount again. Otherwise it will be really tricky for users to make this work correctly
This reverts commit 25b577e.
sebgl
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #620