Parameterize keystore settings addition #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given it's convenient to not use `--stdin` with the ES keystore to fix elastic#1349, this commit makes the keystore settings addition different for ES than for Kibana and the APM Server. Only the Elasticsearch keystore supports settings additions using a file path. Kibana and APM Server supports only to pass the value through stdin and use the --stdin flag.
Contributor
Author
|
✔️ --- PASS: TestUpdateKibanaSecureSettings (210.23s) |
thbkrkr
added a commit
to thbkrkr/cloud-on-k8s
that referenced
this pull request
Jul 25, 2019
Given it's convenient to not use `--stdin` with the ES keystore to fix elastic#1349, this commit makes the keystore settings addition different for ES than for Kibana and the APM Server. Only the Elasticsearch keystore supports settings additions using a file path. Kibana and APM Server supports only to pass the value through stdin and use the --stdin flag.
thbkrkr
added a commit
that referenced
this pull request
Jul 25, 2019
Given it's convenient to not use `--stdin` with the ES keystore to fix #1349, this commit makes the keystore settings addition different for ES than for Kibana and the APM Server. Only the Elasticsearch keystore supports settings additions using a file path. Kibana and APM Server supports only to pass the value through stdin and use the --stdin flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given it's convenient to not use
--stdinwith the ES keystore to fix #1349,this commit makes the keystore settings addition different for ES than
for Kibana and the APM Server.
Only the Elasticsearch keystore supports settings additions using a file
path. Kibana and APM Server supports only to pass the value through
stdin and use the --stdin flag.
Fixes #1399.