Fix version validation #1480
Merged
Fix version validation #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebgl
reviewed
Aug 5, 2019
| } | ||
| } | ||
| return validation.OK | ||
| return validation.Result{Allowed: false, Reason: unsupportedVersion(&ctx.Proposed.Version)} |
Contributor
There was a problem hiding this comment.
Can you include a unit test in Test_supportedVersion() (validations_test.go) to cover what you changed? (which also makes sense outside the webhook world)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a missing check when the version is validated.
Without this PR the webhook does not prevent the user to create a 6.0.0 cluster.