Add metadata for transform node role #3411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch 7.7.0 introduces the transform node role. Add this new node type to the pod metadata when running a version of Elasticsearch that supports transform. Adjust test cases and default values.
Contributor
|
I wonder if we should add |
thbkrkr
approved these changes
Jul 22, 2020
Contributor
thbkrkr
left a comment
There was a problem hiding this comment.
LGTM.
Only left a nit on an unsynced godoc.
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
…into add-transform-node-2
Contributor
|
Relates to #3139. |
This was referenced Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at supporting the transform node role Elasticsearch 7.7.0 introduces.
The complication here is that we now have version specific default configurations. I chose to just toggle the
transformvalue off in the default config to be able to keep using just one config struct. Technically thetransformvalue does not even exist prior to 7.7.0. The default behaviour differs depending on whether the node is a data node or not. On nodes withnode.data: falsenode.transformis alsofalseunless specified otherwise explicitly.