EnterpriseSearch: Set status.ObservedGeneration from metadata.Generation #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/status during reconciliation. Fix broken test, and ensure observed generation is updated during tests. remove unneeded IsConfiguredIfSet change. simplify return logic. remove unneeded log statement.
|
run full pr build |
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
…ion (elastic#5526) * Update enterprise search reconcile logic to update observedgeneration/status during reconciliation. Fix broken test, and ensure observed generation is updated during tests. remove unneeded IsConfiguredIfSet change. simplify return logic. remove unneeded log statement. * Update Enterprise Search e2e mutation tests to check observedGeneration. * update status optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3392
This change allows status.ObservedGeneration to be kept in sync with metadata.Generation according to the rules described in the above issue. This change adds a set of unit tests which show more details into when observedGeneration will, and will not be updated according to any errors/situations that may occur during reconciliation. End to end tests are in place as well.
Remaining Items