Inherit all environment variables from ES container in initContainers #5962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
approved these changes
Aug 23, 2022
Contributor
barkbay
left a comment
There was a problem hiding this comment.
I'm not sure if we should check for the returned value of MainContainer, which maybe nil but LGTM overall.
I think we should also update our documentation here and here to mention this improvement. We can also add the (expected) release version to our documentation, in order to mention that this PR will trigger a rolling restart of the managed Elasticsearch clusters. This will be the case even if user is not using secure settings or advanced topologies. elastic-internal-init-filesystem, I think, will not take advantage of this PR, but I guess it will be the case for elastic-internal-suspend, so I guess we cannot exclude this last one.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5577