Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc update #6182

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Minor doc update #6182

merged 2 commits into from
Nov 22, 2022

Conversation

DJRickyB
Copy link
Contributor

No description provided.

@botelastic botelastic bot added the triage label Nov 18, 2022
@DJRickyB DJRickyB requested a review from pebrc November 18, 2022 20:42
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🙇

It seems however that "ad hoc" comes from Latin words (not from your PR, I just noticed it now). I know that we have tried to avoid latinisms in the past, see #5456 for example.
My feeling is that we should maybe change this title? Maybe Taking JVM heap dumps would be fine?
CC @alaudazzi 👋 who may confirm my statement.

@DJRickyB
Copy link
Contributor Author

I've changed it to something that avoids the potential problem

Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks 👍

@barkbay barkbay merged commit 0535d6b into main Nov 22, 2022
@barkbay barkbay deleted the DJRickyB-patch-1 branch November 22, 2022 07:32
@naemono naemono added the exclude-from-release-notes Exclude this PR from appearing in the release notes label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation exclude-from-release-notes Exclude this PR from appearing in the release notes v2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants