-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More APIs for StackConfigPolicy #6195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file settings secret
5 tasks
pebrc
reviewed
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have not tested it yet. Do we plan to make an exception to the feature freeze for 2.6?
pebrc
approved these changes
Nov 30, 2022
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
naemono
pushed a commit
to naemono/cloud-on-k8s
that referenced
this pull request
Nov 30, 2022
Adds support for more APIs to the StackConfigPolicy custom resource: - Ingest pipelines (/_ingest/pipeline) - Index Lifecycle Policies (/_ilm/policy) - Index templates (/_index_template) - Components templates (/_component_template) - Security Role mappings (/_security/role_mapping) Additional things: - remove managed labels if they are no longer defined when reconciling file settings Secret - fix case 'Settings secret must be updated to reflect the policy settings' in controller_test.go (cherry picked from commit 4f9c235)
naemono
added a commit
that referenced
this pull request
Dec 12, 2022
… for StackConfigPolicy (#6195) | Update eck-diagnostics documentation for filters. (#6191) (#6203) * Version gate for file-based settings volume (#6200) Adds a version gate to configure the file-based settings volume and volumeMounts in the Elasticsearch pods and to reconcile the file-based settings Secret. (cherry picked from commit 42a7f18) * More APIs for StackConfigPolicy (#6195) Adds support for more APIs to the StackConfigPolicy custom resource: - Ingest pipelines (/_ingest/pipeline) - Index Lifecycle Policies (/_ilm/policy) - Index templates (/_index_template) - Components templates (/_component_template) - Security Role mappings (/_security/role_mapping) Additional things: - remove managed labels if they are no longer defined when reconciling file settings Secret - fix case 'Settings secret must be updated to reflect the policy settings' in controller_test.go (cherry picked from commit 4f9c235) * Update eck-diagnostics documentation for filters. (#6191) (cherry picked from commit 747518a) Co-authored-by: Thibault Richard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
Enhancement of existing functionality
exclude-from-release-notes
Exclude this PR from appearing in the release notes
v2.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for more APIs to the StackConfigPolicy custom resource:
Additional things:
For testing (here is a manifest with all settings):
/_cluster/state | jq '.metadata.reserved_state'
should return all configured settings:/_cluster/state | jq '.metadata.reserved_state'
should return no configured settings: