[helm-chart] Include webhook client configuration CA only when certificates are not managed by the operator or cert-manager #6642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bae86fd to
aae8980
Compare
…s are not managed by the operator Signed-off-by: Thibault Richard <[email protected]>
aae8980 to
60009c7
Compare
naemono
approved these changes
Apr 4, 2023
| @@ -12,7 +12,9 @@ metadata: | |||
| {{- end }} | |||
| webhooks: | |||
| - clientConfig: | |||
| {{- if not .Values.webhook.manageCerts }} | |||
There was a problem hiding this comment.
cloud-on-k8s/deploy/eck-operator/values.yaml
Line 106 in bebf07b
Should we also include the check to ensure that certManagerCert is null?
66f657a to
8b92fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the webhook client configuration CA only when certificates are managed by the user, not when they are managed by the operator or cert-manager.
Currently, when certificates are managed by the operator or cert-manager, the webhook manifest is generated with client configuration CA set to
Cg==. As soon as the webhook is created, the operator or cert-manager will generate a cert and update the client configuration CA. This is an issue when deploying ECK with tools like ArgoCD because the tool will indefinitely be in conflict with the operator or cert-manager by always resetting the generated CA.Resolves #6641.