Conditionally set container-suffix in ECK config #6711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
approved these changes
Apr 20, 2023
| container-suffix: {{ .Values.config.containerSuffix }} | ||
| {{- with .Values.config.containerSuffix }} | ||
| container-suffix: {{ . }} | ||
| {{- end }} | ||
| max-concurrent-reconciles: {{ int .Values.config.maxConcurrentReconciles }} | ||
| {{- if .Values.config.passwordHashCacheSize }} |
There was a problem hiding this comment.
Do we want to change all of these if blocks to with blocks for consistency?
https://helm.sh/docs/chart_template_guide/control_structures/
the block after with only executes if the value of PIPELINE is not empty.
There was a problem hiding this comment.
I find the with syntax very nice for readability and figured it was worth starting to use it at the cost of a little break in consistency.
It would be nice to move all the if to with but this is a low hanging fruit: #6716.
pebrc
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the
config.containerSuffixHelm value is not empty before writing it to the ECK configMap data to avoid the side effect of the configMap data being formatted on a single line.I intentionally kept the PR scoped to the bug but we could extend this to all values used in the ECK config.
Resolves #6695.