-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable runAsNonRoot=true for Beats >= 8.8.x #6793
Enable runAsNonRoot=true for Beats >= 8.8.x #6793
Conversation
Add unit test. Add back e2e check. Signed-off-by: Michael Montgomery <[email protected]>
buildkite test this -f p=gke,E2E_TAGS=es -m s=8.7.0,s=7.17.10,s=8.8.0-SNAPSHOT |
Signed-off-by: Michael Montgomery <[email protected]>
buildkite test this -f p=gke,E2E_TAGS=es -m s=8.7.0,s=7.17.10,s=8.8.0-SNAPSHOT |
8.7.0 and 7.17.0 failed in BK because of invalid logic in e2e tests, which I've fixed, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michael Montgomery <[email protected]>
Since elastic/beats#35272 was merged, and backported into upcoming 8.8 Beats release, we should be able to enable
runAsNonRoot=true
for beats now > 8.8.x.Testing Done
With manifest at
8.8.0-SNAPSHOT
With same manifest with
8.7.0
TODO: e2e tests verification
es
on8.8.0-SNAPSHOT
es
on8.7.0