-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly set pipeline version on new pipelines #698
Properly set pipeline version on new pipelines #698
Conversation
cafa712
to
d17228e
Compare
// creating new pipeline | ||
pipelineJson = this.canvasController.getPipelineFlow(); | ||
if (Utils.isNewPipeline(pipelineJson)) { | ||
pipelineJson.pipelines[0]['app_data']['version'] = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this to just be baked into the template but I see that's just for creating single-node pipelines for batch notebook processing. Seems like we should be consistent and add a 'version': 1
field to the template as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Luciano.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Developer's Certificate of Origin 1.1