Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set pipeline version on new pipelines #698

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

lresende
Copy link
Member

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende added the component:pipeline-editor pipeline editor label Jun 29, 2020
@lresende lresende added this to the 1.0.0 milestone Jun 29, 2020
@lresende lresende force-pushed the add-version-to-new-pipelines branch from cafa712 to d17228e Compare June 29, 2020 06:10
// creating new pipeline
pipelineJson = this.canvasController.getPipelineFlow();
if (Utils.isNewPipeline(pipelineJson)) {
pipelineJson.pipelines[0]['app_data']['version'] = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected this to just be baked into the template but I see that's just for creating single-node pipelines for batch notebook processing. Seems like we should be consistent and add a 'version': 1 field to the template as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by template?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Luciano.

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lresende lresende merged commit c63bf65 into elyra-ai:master Jun 29, 2020
@lresende lresende deleted the add-version-to-new-pipelines branch June 29, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants