Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code snippet deletion bug #748

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Fix code snippet deletion bug #748

merged 2 commits into from
Jul 13, 2020

Conversation

marthacryan
Copy link
Member

Fixes #736. Adds a boolean to indicate that the cancel button was clicked on delete.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@marthacryan marthacryan requested a review from ajbozarth July 10, 2020 17:20
@marthacryan marthacryan added component:code-snippets Code Snippet Extension kind:bug Something isn't working labels Jul 10, 2020
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggested var rename but otherwise this LGTM. If I get time to test this locally before it's merged I'll update with an "approve"

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and it works great, once you address my previous comments (on readability and documentation) then this will be LGTM

@marthacryan marthacryan requested a review from ajbozarth July 13, 2020 21:22
@lresende lresende merged this pull request into elyra-ai:master Jul 13, 2020
lresende pushed a commit that referenced this pull request Jul 13, 2020
@marthacryan marthacryan deleted the delete-snippet-bug branch July 24, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:code-snippets Code Snippet Extension kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code snippet widget disappears
4 participants