Migrate to the latest version of canvas

[vabarbosa]

Migrate to the latest canvas version

• Upgrade @elyra/canvas (from 6.1.23 to 8.0.32)
• Resolve breaking changes
• Clean-up the UI
• Verify ui tests
• Update documentation screenshots
• Confirm canvas upgrade fixes issues:
  • Pipeline editor prevents multiple input links on first node added after open #750 (part 2) // will be resolved in canvas 9.0.x
  • icon svg support
  • Throw exception when multipipeline or supernode found when parsing pipeline blueprint #386
• Merge (upcoming) Pipeline editor PRs:
  • Disable toolbar buttons on empty pipeline editor #741
  • Add error message on attempt to create circular references #744 // will be merged after this PR
  • Pipeline editor prevents multiple input links on first node added after open #750 (part 1)
  • Add indicator for invalid node properties #752 // may be merged after this PR

Changes

• per @elyra/canvas release 7.0.5

  • Updated dependency react-intl (^3.0.0)
  • Added dependency react-redux (^7.0.0)

• per @elyra/canvas release 8.0.1

  • Updated CSS class names and styling
  • Placed <CommonCanvas> inside a <IntlProvider>
  • Removed toolbarMenuActionHandler. Handling of these actions moved to the editActionHandler
  • Removed contextMenuActionHandler. Handling of these actions moved to the editActionHandler.
  • Renamed addComment action to createAutoComment
  • Renamed delete action to deleteSelectedObjects

• per @elyra/canvas release 8.0.2

  • Added config createSupernode // user can disable creation of supernodes via configuration parameter

• per @elyra/canvas release 8.0.4

  • Added config enableInsertNodeDroppedOnLink // user can drag nodes from the palette and drop them onto existing links in the flow which causes the node to be inserted between the two nodes joined by the link

• Update screenshots in documentation

Fixes #645

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

[vabarbosa]

all the major work is dont here and it is basically ready for reviews.

all that is left would be to merge with #744 and #752 (and resolve conflicts) once they are ready.

the second part of #750 (cardinality being deleted) cannot be confirmed as it was addressed in canvas yesterday and won't be available until next canvas release. the first part (incorrect cardinality) is addressed in #759

[marthacryan]

Just tried this out locally and it looks great! So sleek! For those who don't have time to check out the PR locally this is what the new canvas looks like:

As for #744, I think actually it might be a good idea to merge this PR first, because I think there's a handler in the newer version of canvas that would simplify that PR (beforeEditActionHandler).

We'll also need to update the pipeline documentation images to use the new interface.

[vabarbosa]

Just tried this out locally and it looks great! So sleek! For those who don't have time to check out the PR locally this is what the new canvas looks like:

As for #744, I think actually it might be a good idea to merge this PR first, because I think there's a handler in the newer version of canvas that would simplify that PR (beforeEditActionHandler).

We'll also need to update the pipeline documentation images to use the new interface.

thanks for the reminder. i'll update to documentation images. this can be merged first if it is going to simplify #744

[karlaspuldaro]

This is awesome! Works great.

We can create an issue to look at the paste button always enabled. On my last PR I thought it was behaving like that because I always had a node on the clipboard.

[vabarbosa]

this PR is good to go for @elyra/canvas v8.0.32.
however, v9 has just been published. i will upgrade to v9 instead and resolve any issues that may arise.

[marthacryan]

@vabarbosa Also, feel free to merge this before #752 merges as well and I can rebase. It seems like there's more to discuss on that PR than there is here.

[ajbozarth]

I'll be reviewing this early this afternoon, will post code and UX reviews as I finish each

[ajbozarth]

Code and UX LGTM but I found some UI issues on Safari (surprise surprise Safari again >.<). I've attached screen shots of the oddities below:


As you can see some of the borders and mouse over are missing or misaligned. No idea why it is like this on Safari and not Chrome.

[vabarbosa]

Code and UX LGTM but I found some UI issues on Safari (surprise surprise Safari again >.<). I've attached screen shots of the oddities below:
As you can see some of the borders and mouse over are missing or misaligned. No idea why it is like this on Safari and not Chrome.

thanks, Safari discrepancies should be resolved.