Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer value of bool secure parameter from endpoint scheme #774

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

kevin-bates
Copy link
Member

This change removes the need for maintaining an optional cos_secure field in the metadata instance by inferring its boolean value from the scheme of the corresponding cos_endpoint value (which is required).

Also updated the docs accordingly. Since the example, recommended setting the previous cos_secure to True, the endpoint in the example is now prefixed with a scheme of https

Resolves #417

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lresende lresende merged commit 77ea803 into elyra-ai:master Jul 25, 2020
@kevin-bates kevin-bates deleted the infer-cos-secure branch August 3, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify usage of cos_secure for kfp runtime metadata
2 participants