Update UI integration tests to use non-standard port #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current UI tests will fail if jupyter lab or any other application is using port 8888. The issue is resolved by Using an explicit non-registered port >=49152 Fixes elyra-ai#1011
|
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
marthacryan
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
I actually added this into #1020 but it'd just be on the jupyterlab3 branch so this is probably a better idea :) Aside from the port number this is exactly what I changed so LGTM
Saw that after...lol...my bad. Anywho, perhaps using a port in the dynamic range would be better in the long run to avoid any issues with any other applications. |
lresende
approved these changes
Oct 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current UI tests will fail if jupyter lab or any other application
is using port 8888. The issue is resolved by using an explicit
non-registered port >=49152
Fixes #1011