-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variable formatting in jinja template used by export #1027
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
The latest update produces the following output:
Note the path prefix Neither the original pipeline file
nor the generated tar archives contain the path information:
|
pipeline_outputs={{ operation.pipeline_outputs }}, | ||
image='{{ operation.image }}') | ||
|
||
notebook_op_{{ loop.index }}.name = '{{ operation.name }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify why we are overriding the name instead of setting it to the appropriate value right away?
notebook_op_{{ loop.index }} = NotebookOp(name='{{ operation_id }}',
...
notebook_op_{{ loop.index }}.name = '{{ operation.name }}'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is the question here, if is regarding using operation_id
versus operation.name
, we definitely don't want to use the id
as the operation name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this had to do with the way the notebook op initializes its parent classes.
Confirmed that the exported Python DSL works as expected for the tutorial pipeline. |
The exported YAML file still uses fully qualified names
We wouldn't have these issues if export would always generate Python DSL first, and then if YAML was selected as output format, compile the DSL to produce the final output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and compared before/after results. LGTM
pipeline_outputs={{ operation.pipeline_outputs }}, | ||
image='{{ operation.image }}') | ||
|
||
notebook_op_{{ loop.index }}.name = '{{ operation.name }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is the question here, if is regarding using operation_id
versus operation.name
, we definitely don't want to use the id
as the operation name.
-Remove single quotes for pipeline input and outputs -Add link and description to pipeline experiment -Filter paths from artifact names Fixes elyra-ai#1025
-Remove single quotes for pipeline input and outputs
-Add link and description to pipeline experiment
-Filter paths from artifact names
Fixes #1025
Developer's Certificate of Origin 1.1