Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on containers and public container registries #1039

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

pacospace
Copy link
Contributor

@pacospace pacospace commented Nov 5, 2020

Signed-off-by: Francesco Murdaca fmurdaca@redhat.com

Fixes: #1035 updating Elyra documentation generalizing on container and container registries.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
@elyra-bot
Copy link

elyra-bot bot commented Nov 5, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@pacospace pacospace changed the title Update documentation on public container registries Update documentation on containers and public container registries Nov 5, 2020
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads good to me..=)

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


##### Image Name (image_name)
The name and tag of an existing Docker image in the public Docker Hub container registry that meets the stated prerequisites. This property is required.

The name and tag of an existing container image in a public container registry that meets the stated prerequisites. This property is required.

Example: `jdoe/my-image:1.0.0`
Copy link
Member

@ptitzler ptitzler Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add another example that illustrates what this would look like for a third party container registry e.g. quay.io/jdoe/my-image:1.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 453592b

Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged commit bf4c57d into elyra-ai:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use images from other registries
4 participants