-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on containers and public container registries #1039
Conversation
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads good to me..=)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
##### Image Name (image_name) | ||
The name and tag of an existing Docker image in the public Docker Hub container registry that meets the stated prerequisites. This property is required. | ||
|
||
The name and tag of an existing container image in a public container registry that meets the stated prerequisites. This property is required. | ||
|
||
Example: `jdoe/my-image:1.0.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add another example that illustrates what this would look like for a third party container registry e.g. quay.io/jdoe/my-image:1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 453592b
Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
5e8c5cd
to
453592b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Francesco Murdaca fmurdaca@redhat.com
Fixes: #1035 updating Elyra documentation generalizing on container and container registries.
Developer's Certificate of Origin 1.1