Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure local notebook nodes use local env #1061

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

kevin-bates
Copy link
Member

This change mirrors that of #1047 but for notebooks. Also, the local environment should be copied so as to not be side-affected by updates.

Updated the tests to include a pip install and import of the installed module to ensure its completion. If there are other lighter and more obscure packages than pygithub, suggestions are welcome. The primary requirement is that it can't exist prior to CI.

Fixes #1058

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@elyra-bot
Copy link

elyra-bot bot commented Nov 11, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende added this to the 1.4.1 milestone Nov 11, 2020
@lresende lresende merged commit 0534cc4 into elyra-ai:master Nov 12, 2020
@kevin-bates kevin-bates deleted the fix-local-notebook-envs branch November 14, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local pipeline fails when a notebook install dependencies
2 participants