Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle references to missing schema files #1096

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

kevin-bates
Copy link
Member

References to "missing" schema (which can include typos in the schema_name value) were not handled correctly, leading to an unhandled exception. These changes include such occurrences as invalid metadata and will include such results upon request (and not be unhandled). The custom-defined errors now derive from Exception rather than BaseException to accommodate this change - which is probably better anyway.

Note since issue #1093 was not marked for elyra 2.x, I'm including it in master for now. These changes should easily migrate to the elyra 2.x branch when that is officially built.

Fixes #1093

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Nov 21, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende added this to the 1.4.2 milestone Nov 21, 2020
@lresende lresende merged commit c0ba856 into elyra-ai:master Nov 21, 2020
@kevin-bates kevin-bates deleted the missing-schema branch December 17, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elyra crashes when it is unable to find a pipeline runtime schema definition
2 participants