Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update container-image targets in Makefile #1141

Merged
merged 1 commit into from
Dec 9, 2020
Merged

update container-image targets in Makefile #1141

merged 1 commit into from
Dec 9, 2020

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Dec 7, 2020

This PR:

  • renames the existing [Elyra] docker-image target to container-image (so we start using more general terminology)
  • adds a publish-container-image target, which pushes the Elyra container image to Docker Hub and quay.io. This is a privileged task and only users with the appropriate access to the target project on hub.docker.com and quay.io can perform it by default, after they've logged in to the registries.

The main goal of this PR is to assure that each task in the Elyra lifecycle is "documented", which is not yet the case for the container image publication process is not, as far as I can tell scanning at the documentation.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added component:build build and build related issues(dependencies and docker) component:docker Container/Docker images related issues labels Dec 7, 2020
@elyra-bot
Copy link

elyra-bot bot commented Dec 7, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler
Copy link
Member Author

ptitzler commented Dec 7, 2020

Please let me know if such is change is okay. If it is'll add one more commit to reflect the change in the appropriate documentation topic https://elyra.readthedocs.io/en/latest/developer_guide/development-workflow.html#building-the-elyra-container-image

Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the directory names as well or does it still make sense to keep them as is?

@ptitzler
Copy link
Member Author

ptitzler commented Dec 8, 2020

For the sake of consistency I would be in favor to do that too, but the main gap I was trying to close is the lack of "documentation" of the publication process. Even though there are just a few folks actually performing the container image publication, anybody should be able to easily find out how it is done. FWIW I stumbled across this when I was looking for clues about how latest images are formally built and released and checked the Makefile)

@lresende lresende added this to the 1.4.3 milestone Dec 9, 2020
@lresende lresende merged commit 5b31aad into elyra-ai:master Dec 9, 2020
lresende pushed a commit that referenced this pull request Dec 9, 2020
Renames the existing Elyra make docker-image target to container-image
(so we start using more general terminology). 

It also adds a publish-container-image target, which pushes the Elyra
container image to Docker Hub and Quay.io. Note that publish is a privileged
task and only users with the appropriate access to the target project on 
hub.docker.com and quay.io can perform it by default after they've
logged in to the registries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) component:docker Container/Docker images related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants